Skip to content

harbor-cli 0.0.14 (new formula) #250518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

harbor-cli 0.0.14 (new formula) #250518

merged 2 commits into from
Oct 29, 2025

Conversation

@chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Oct 21, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copilot AI review requested due to automatic review settings October 21, 2025 14:24
Copilot AI reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Homebrew formula for harbor-cli version 0.0.13, a CLI tool for managing Harbor container registries.

Key Changes:

  • New formula file introducing harbor-cli package
  • Build configuration with Go and version-embedded ldflags
  • Shell completion generation for bash, zsh, fish, and pwsh
  • Basic tests verifying version output and error handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 21, 2025
@botantony
Copy link
Member

botantony commented Oct 21, 2025

Looks like it tries to access macOS keychain during installation and waits for user input, that's why it hangs
Screenshot 2025-10-21 at 18 10 02

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 21, 2025
@chenrui333 chenrui333 mentioned this pull request Oct 21, 2025
Merged
@chenrui333
Copy link
Member Author

chenrui333 commented Oct 21, 2025

Looks like it tries to access macOS keychain during installation and waits for user input, that's why it hangs

adding a upstream patch, goharbor/harbor-cli#562

@chenrui333 chenrui333 marked this pull request as draft October 21, 2025 18:25
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Oct 21, 2025
@chenrui333 chenrui333 changed the title harbor-cli 0.0.13 (new formula) harbor-cli 0.0.14 (new formula) Oct 29, 2025
@chenrui333 chenrui333 removed in progress Stale bot should stay away CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 29, 2025
@chenrui333 chenrui333 marked this pull request as ready for review October 29, 2025 00:12
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 29, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 29, 2025 01:50
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit a3eb9ad Oct 29, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the harbor-cli branch October 29, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@branchvincent branchvincent branchvincent approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@botantony botantony botantony approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chenrui333 @botantony @branchvincent @daeho-ro @BrewTestBot